src/com/wjholden/nmap/Nmap.java
1   A high number of imports can indicate a high degree of coupling within an object.
47   The class 'Nmap' has a Cyclomatic Complexity of 7 (Highest = 45).
47   This class has too many methods, consider refactoring it.
47   Too many fields
51   Found non-transient, non-static member. Please mark as transient or provide accessors.
56   Found non-transient, non-static member. Please mark as transient or provide accessors.
61   Found non-transient, non-static member. Please mark as transient or provide accessors.
66   Found non-transient, non-static member. Please mark as transient or provide accessors.
71   Found non-transient, non-static member. Please mark as transient or provide accessors.
71   Perhaps 'mHelp' could be replaced by a local variable.
76   Perhaps 'mShare' could be replaced by a local variable.
94   Avoid excessively long variable names like installationVerified
114   Avoid variables with short names like sh
140   Avoid variables with short names like h
147   Avoid variables with short names like pd
157   Perhaps 'preferencesEditor' could be replaced by a local variable.
165   The field name indicates a constant but its modifiers do not
165   Variables should start with a lowercase character
171   Avoid variables with short names like ne
176   Perhaps 'wifiManager' could be replaced by a local variable.
181   Perhaps 'wifiInfo' could be replaced by a local variable.
184   Avoid excessively long variable names like savedInstanceState
184   Avoid really long methods.
184   Parameter 'savedInstanceState' is not assigned and could be declared final
184   The method 'onCreate' has a Cyclomatic Complexity of 45.
184   The method onCreate() has an NPath complexity of 826200
198   Local variable 'adapterCommand' could be declared final
206   Parameter 'arg0' is not assigned and could be declared final
206   Parameter 'arg1' is not assigned and could be declared final
207   Parameter 'arg2' is not assigned and could be declared final
207   Parameter 'arg3' is not assigned and could be declared final
222   Local variable 'adapterOutput' could be declared final
246   Local variable 'target' could be declared final
250   Local variable 'args' could be declared final
255   Local variable 'result' could be declared final
258   The String literal "installationVerified" appears 4 times in this file; the first occurrence is on line 258
260   The String literal "hasRunOneScan" appears 4 times in this file; the first occurrence is on line 260
262   The String literal "canGetRoot" appears 4 times in this file; the first occurrence is on line 262
301   Avoid variables with short names like ip
302   Avoid using if statements without curly braces
311   The method 'handleMessage' has a Cyclomatic Complexity of 15.
313   Found 'DU'-anomaly for variable 'alert' (lines '313'-'484').
313   Found 'DU'-anomaly for variable 'alert' (lines '313'-'484').
313   Found 'DU'-anomaly for variable 'alert' (lines '313'-'484').
313   Found 'DU'-anomaly for variable 'alert' (lines '313'-'484').
313   Found 'DU'-anomaly for variable 'alert' (lines '313'-'484').
313   Found 'DU'-anomaly for variable 'alert' (lines '313'-'484').
313   Found 'DU'-anomaly for variable 'alert' (lines '313'-'484').
313   Found 'DU'-anomaly for variable 'alert' (lines '313'-'484').
313   Found 'DU'-anomaly for variable 'alert' (lines '313'-'484').
313   Found 'DU'-anomaly for variable 'alert' (lines '313'-'484').
319   An empty statement (semicolon) not part of a loop
321   Avoid if (x != y) ..; else ..;
322   Avoid using if...else statements without curly braces
324   Avoid using if...else statements without curly braces
347   Position literals first in String comparisons
348   Avoid using if...else statements without curly braces
349   Position literals first in String comparisons
350   Avoid using if...else statements without curly braces
351   Position literals first in String comparisons
352   Avoid using if...else statements without curly braces
360   Avoid assignments in operands
360   Found 'DU'-anomaly for variable 'l' (lines '360'-'484').
360   Found 'DU'-anomaly for variable 'l' (lines '360'-'484').
360   Found 'DU'-anomaly for variable 'l' (lines '360'-'484').
360   Found 'DU'-anomaly for variable 'l' (lines '360'-'484').
360   Found 'DU'-anomaly for variable 'l' (lines '360'-'484').
360   Found 'DU'-anomaly for variable 'l' (lines '360'-'484').
360   Found 'DU'-anomaly for variable 'l' (lines '360'-'484').
360   Found 'DU'-anomaly for variable 'l' (lines '360'-'484').
360   Found 'DU'-anomaly for variable 'l' (lines '360'-'484').
360   Found 'DU'-anomaly for variable 'l' (lines '360'-'484').
424   Avoid using if statements without curly braces
425   Found 'DU'-anomaly for variable 's' (lines '425'-'484').
425   Found 'DU'-anomaly for variable 's' (lines '425'-'484').
425   Found 'DU'-anomaly for variable 's' (lines '425'-'484').
425   Found 'DU'-anomaly for variable 's' (lines '425'-'484').
425   Found 'DU'-anomaly for variable 's' (lines '425'-'484').
425   Found 'DU'-anomaly for variable 's' (lines '425'-'484').
425   Found 'DU'-anomaly for variable 's' (lines '425'-'484').
425   Found 'DU'-anomaly for variable 's' (lines '425'-'484').
425   Found 'DU'-anomaly for variable 's' (lines '425'-'484').
425   Found 'DU'-anomaly for variable 's' (lines '425'-'484').
488   Avoid instantiating String objects; this is usually unnecessary.
493   Avoid instantiating String objects; this is usually unnecessary.
498   Avoid using if statements without curly braces
500   Avoid using if statements without curly braces
506   Avoid excessively long variable names like savedInstanceState
514   Avoid using if statements without curly braces
578   Use bitwise inversion to invert boolean values

 src/com/wjholden/nmap/NmapError.java
21   Avoid using implementation types like 'ArrayList'; use the interface instead
21   Avoid using implementation types like 'ArrayList'; use the interface instead
21   Found non-transient, non-static member. Please mark as transient or provide accessors.
21   Private field 'errors' could be made final; it is only initialized in the declaration or constructor.
33   Avoid variables with short names like s
33   Method names should not start with capital letters
33   Parameter 's' is not assigned and could be declared final
42   Avoid using if statements without curly braces
50   Method names should not start with capital letters
52   Avoid variables with short names like s
53   Local variable 'stop' could be declared final
56   Prefer StringBuffer over += for concatenating strings

 src/com/wjholden/nmap/NmapUtilities.java
18   All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning.
27   Avoid variables with short names like c
27   Parameter 'c' is not assigned and could be declared final
29   Local variable 'tmpdir' could be declared final
46   Local variable 'msg' could be declared final
65   Local variable 'path' could be declared final
66   Avoid variables with short names like st
66   Local variable 'st' could be declared final
69   Local variable 'token' could be declared final
70   Avoid instantiating new objects inside loops
76   A method should have only one exit point, and that should be the last statement in the method
76   This statement may have some unnecessary parentheses
84   This statement may have some unnecessary parentheses
92   Avoid variables with short names like c
92   Parameter 'c' is not assigned and could be declared final
95   A method should have only one exit point, and that should be the last statement in the method
95   This statement may have some unnecessary parentheses
98   This statement may have some unnecessary parentheses
109   Parameter 'myDataDir' is not assigned and could be declared final
119   This statement may have some unnecessary parentheses

 src/com/wjholden/nmap/Nmap_Constants.java
12   An Interface should be used only to model a behaviour; consider converting this to a class.
16   Avoid modifiers which are implied by the context
21   Avoid modifiers which are implied by the context
26   Avoid modifiers which are implied by the context
31   Avoid modifiers which are implied by the context
36   Avoid modifiers which are implied by the context
55   Avoid excessively long variable names like MENU_ITEM_DEBUG_ENABLE
56   Avoid excessively long variable names like MENU_ITEM_DEBUG_EMAIL
57   Avoid excessively long variable names like MENU_ITEM_MORE_HELP
58   Avoid excessively long variable names like MENU_ITEM_REINSTALL
62   Avoid excessively long variable names like MENU_GROUP_EXTRA_OPTIONS

 src/com/wjholden/nmap/scan.java
25   Class names should begin with an uppercase character
25   The class 'scan' has a Cyclomatic Complexity of 10 (Highest = 20).
27   Found non-transient, non-static member. Please mark as transient or provide accessors.
28   Avoid excessively long variable names like executionParameters
28   Found non-transient, non-static member. Please mark as transient or provide accessors.
28   Perhaps 'executionParameters' could be replaced by a local variable.
29   Avoid variables with short names like c
29   Found non-transient, non-static member. Please mark as transient or provide accessors.
29   Perhaps 'c' could be replaced by a local variable.
31   Avoid variables with short names like os
31   Found non-transient, non-static member. Please mark as transient or provide accessors.
31   Perhaps 'os' could be replaced by a local variable.
32   Avoid variables with short names like in
32   Found non-transient, non-static member. Please mark as transient or provide accessors.
32   Perhaps 'in' could be replaced by a local variable.
33   Perhaps 'err' could be replaced by a local variable.
34   Avoid variables with short names like p
38   Switch statements should have a default label
41   Avoid instantiating String objects; this is usually unnecessary.
68   Avoid variables with short names like v
68   Parameter 'v' is not assigned and could be declared final
78   Avoid really long methods.
78   Parameter 'params' is not assigned and could be declared final
78   The method 'doInBackground' has a Cyclomatic Complexity of 20.
78   The method doInBackground() has an NPath complexity of 59904
82   Avoid using if statements without curly braces
102   Local variable 'msg' could be declared final
106   A method should have only one exit point, and that should be the last statement in the method
106   This statement may have some unnecessary parentheses
109   Avoid using if...else statements without curly braces
113   Local variable 'msg' could be declared final
117   A method should have only one exit point, and that should be the last statement in the method
117   This statement may have some unnecessary parentheses
124   Avoid using if statements without curly braces
126   Avoid using if statements without curly braces
128   Avoid using if statements without curly braces
139   Position literals first in String comparisons
140   Avoid using if...else statements without curly braces
172   Avoid assignments in operands
175   Prefer StringBuffer over += for concatenating strings
179   Local variable 'msg1' could be declared final
186   Local variable 'msg' could be declared final
194   Avoid assignments in operands
196   Local variable 'msg' could be declared final
219   Avoid using if statements without curly braces
219   Position literals first in String comparisons
221   This statement may have some unnecessary parentheses

 src/com/wjholden/nmap/verifyInstallation.java
28   Class names should begin with an uppercase character
28   The class 'verifyInstallation' has a Cyclomatic Complexity of 8 (Highest = 20).
33   Avoid excessively long variable names like installationResults
33   Found non-transient, non-static member. Please mark as transient or provide accessors.
38   Found non-transient, non-static member. Please mark as transient or provide accessors.
38   Private field 'filenames' could be made final; it is only initialized in the declaration or constructor.
43   Found non-transient, non-static member. Please mark as transient or provide accessors.
43   Private field 'requiredResources' could be made final; it is only initialized in the declaration or constructor.
48   Found non-transient, non-static member. Please mark as transient or provide accessors.
50   Found non-transient, non-static member. Please mark as transient or provide accessors.
50   Perhaps 'resources' could be replaced by a local variable.
52   Avoid variables with short names like v
52   Parameter 'v' is not assigned and could be declared final
59   Avoid really long methods.
59   Parameter 'params' is not assigned and could be declared final
59   The method 'doInBackground' has a Cyclomatic Complexity of 20.
59   The method doInBackground() has an NCSS line count of 102
59   The method doInBackground() has an NPath complexity of 43920
61   Found 'DU'-anomaly for variable 'buf' (lines '61'-'244').
61   Local variable 'buf' could be declared final
62   Avoid if (x != y) ..; else ..;
63   Avoid using if...else statements without curly braces
65   A method should have only one exit point, and that should be the last statement in the method
65   Avoid using if...else statements without curly braces
75   Local variable 'in_nmap_a' could be declared final
76   Local variable 'in_nmap_b' could be declared final
77   Local variable 'in_nmap_c' could be declared final
78   Local variable 'out_nmap' could be declared final
102   A method should have only one exit point, and that should be the last statement in the method
102   This statement may have some unnecessary parentheses
113   Avoid using while statements without curly braces
116   Avoid using while statements without curly braces
127   A method should have only one exit point, and that should be the last statement in the method
127   This statement may have some unnecessary parentheses
138   Avoid instantiating new objects inside loops
152   A method should have only one exit point, and that should be the last statement in the method
152   This statement may have some unnecessary parentheses
162   Avoid variables with short names like p
163   Avoid variables with short names like os
164   Avoid variables with short names like in
201   Avoid variables with short names like e
202   Avoid assignments in operands
206   Avoid assignments in operands
231   A method should have only one exit point, and that should be the last statement in the method
231   This statement may have some unnecessary parentheses
237   This statement may have some unnecessary parentheses
246   Parameter 'path' is not assigned and could be declared final